fix(cdp): Ask for kinesis stream name, not the ARN #25711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarconLP
approved these changes
Oct 21, 2024
This was referenced Oct 21, 2024
fuziontech
added a commit
that referenced
this pull request
Oct 21, 2024
* master: (100 commits) revert: perf: Speed up filtering persons (#25715) chore: count data ingested by source (#25714) fix(bi): Dont try to be too clever with variables (#25712) fix(cdp): Ask for kinesis stream name, not the ARN (#25711) fix(batch-exports): Deal with deeply nested events (#25710) fix(batch-exports): Ingest as JSON in Redshift super type (#25709) perf: Speed up filtering persons (#25604) feat(data-warehouse): Add button to cancel batch export backfill run (#25706) feat(cdp): add discord template (#25649) feat(max): Show query summary (#25696) feat(errors): Use exception list and remove stack trace raw (#25655) fix: smaller cohort resource usage for replay filters (#25699) chore: use meta columns in data visualization table (#25697) feat(cdp): add klaviyo templates (#25693) feat(max): Answer feedback buttons (#25670) feat(cdp): add google ads integration warning (#25698) feat(hog): print ast in console (#25608) feat(data-warehouse): edit SQL based import configs (#25685) fix(insights): handle negation property in cohort property filters (#25691) fix: warming and filter (#25674) ...
timgl
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This misled a user, who then filed a support ticket because our debugging story isn't quite as nice as it should be. Improving the debug story is in progress, but we can make this fix quickly now too.