Skip to content

Commit

Permalink
fix(cdp): Ask for kinesis stream name, not the ARN (#25711)
Browse files Browse the repository at this point in the history
  • Loading branch information
oliverb123 authored Oct 21, 2024
1 parent 298a502 commit 172e068
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions posthog/cdp/templates/aws_kinesis/template_aws_kinesis.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
let date := formatDateTime(now(), '%Y%m%d')
let payload := jsonStringify({
'StreamName': inputs.aws_kinesis_stream_arn,
'StreamName': inputs.aws_kinesis_stream_name,
'PartitionKey': inputs.aws_kinesis_partition_key ?? generateUUIDv4(),
'Data': base64Encode(jsonStringify(inputs.payload)),
})
Expand Down Expand Up @@ -108,9 +108,9 @@
"default": "us-east-1",
},
{
"key": "aws_kinesis_stream_arn",
"key": "aws_kinesis_stream_name",
"type": "string",
"label": "Kinesis Stream ARN",
"label": "Kinesis Stream Name",
"secret": False,
"required": True,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def test_function_works(self):
"aws_access_key_id": "aws_access_key_id",
"aws_secret_access_key": "aws_secret_access_key",
"aws_region": "aws_region",
"aws_kinesis_stream_arn": "aws_kinesis_stream_arn",
"aws_kinesis_stream_name": "aws_kinesis_stream_arn",
"aws_kinesis_partition_key": "1",
"payload": {"hello": "world"},
}
Expand Down

0 comments on commit 172e068

Please sign in to comment.