feat(experiments HogQL rewrite): fetch associated Experiment #24992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
dmarticus
approved these changes
Sep 17, 2024
Comment on lines
-27
to
+31
| variants = self.query.variants | ||
| variants = self.feature_flag.variants |
There was a problem hiding this comment.
forgive me if I'm out of the loop, but what's the ramifications/rationale behind moving the variants to come from the feature flag instead of the query?
There was a problem hiding this comment.
The way I think about this - the experiment (and its linked flag) is the source of truth for experiment variants. We need to retrieve it in the query runner for other things too, so might as well retrieve the variants from there, no need to pass via the query.
dmarticus
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24914
Changes
experiment_idto the experiment query runnersExperimentin the query runnerFeatureFlagmetricsfield on theExperiment- I don't see a reason not to, as we want to treat them in the same way in the UI (possibly subject to change later).How did you test this code?
Updated existing tests