Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments HogQL rewrite #24914

Open
17 of 22 tasks
jurajmajerik opened this issue Sep 11, 2024 · 1 comment
Open
17 of 22 tasks

Experiments HogQL rewrite #24914

jurajmajerik opened this issue Sep 11, 2024 · 1 comment
Labels
enhancement New feature or request feature/experimentation Feature Tag: Experimentation

Comments

@jurajmajerik
Copy link
Contributor

jurajmajerik commented Sep 11, 2024

Trends

  • Set up a query runner
  • Retrieve Experiment
  • Prepare Trend query
    • Display type
    • Start/end dates
    • Flag breakdown
  • Prepare exposure query
    • Events/actions
    • Start/end dates
    • Flag breakdown
    • Default feature flag exposure filter
  • Handle math aggregation path
  • Add statistical calculations
  • Custom errors
  • Filter out test accounts
  • Copy over existing tests

Funnels

  • Set up a query runner
  • Retrieve Experiment
  • Prepare Funnel query
    • Display type
    • Start/end dates
    • Flag breakdown
    • Reset properties
  • Add statistical calculations
  • Custom errors
  • Filter out test accounts
  • Copy over existing tests

Schema migration

  • Add a metrics field
  • Migrate Experiment records

Frontend

  • Call /query - primary metric
  • Call /query - secondary metrics
  • Ensure backwards compatibility (transform filters to query)
  • Retrieve from cache vs. recalculate

Debug info

- [ ] PostHog Cloud, Debug information: [please copy/paste from https://us.posthog.com/settings/project-details#variables]
- [ ] PostHog Hobby self-hosted with `docker compose`, version/commit: [please provide]
- [ ] PostHog self-hosted with Kubernetes (deprecated, see [`Sunsetting Kubernetes support`](https://posthog.com/blog/sunsetting-helm-support-posthog)), version/commit: [please provide]
@abigailbramble
Copy link

https://posthoghelp.zendesk.com/agent/tickets/19665 and https://posthoghelp.zendesk.com/agent/tickets/19431
both seeing experiment results affected by anonymous events.
It looks like experiments are unintentionally filtering out anonymous people: see this thread
This will be fixed by the above migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/experimentation Feature Tag: Experimentation
Projects
None yet
Development

No branches or pull requests

2 participants