Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device::init_log() should not accept parameters #169

Closed
Tracked by #168
PoorRican opened this issue May 10, 2023 · 0 comments · Fixed by #176
Closed
Tracked by #168

Device::init_log() should not accept parameters #169

PoorRican opened this issue May 10, 2023 · 0 comments · Fixed by #176

Comments

@PoorRican
Copy link
Owner

PoorRican commented May 10, 2023 •
edited
Loading

Instead of relying on user to pass settings parameter in Device::init_log(). Group::push_input() and Group::push_output() should automatically update reference to root_path. This must be tested.
This was referenced May 10, 2023
Closed
Closed
@PoorRican PoorRican changed the title Group::init_log() should not be passed any parameter. Group::push_input() and Group::push_output() should automatically update reference to root_path. This must be tested. Device::init_log() should not accept parameters May 10, 2023
PoorRican added a commit that referenced this issue May 11, 2023
@PoorRican
Device::init_log() should not accept parameters #169
41c4ce8
@PoorRican PoorRican mentioned this issue May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.1.0-beta Release
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Group PoorRican/sensd
1 participant
@PoorRican