Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group should not store Def<Settings> directly #168

Closed
3 tasks done
PoorRican opened this issue May 10, 2023 · 0 comments · Fixed by #176
Closed
3 tasks done

Group should not store Def<Settings> directly #168

PoorRican opened this issue May 10, 2023 · 0 comments · Fixed by #176

Comments

@PoorRican
Copy link
Owner

PoorRican commented May 10, 2023 •
edited
Loading

There is no reason to store a reference to Settings. Rather, Group only needs access to root_path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.1.0-beta Release
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Group PoorRican/sensd
1 participant
@PoorRican