refactor: use SDK-native types for CLI parsing, centralize client initialization & output helpers#13
Open
suhailkakar wants to merge 5 commits intomainfrom
Open
refactor: use SDK-native types for CLI parsing, centralize client initialization & output helpers#13suhailkakar wants to merge 5 commits intomainfrom
suhailkakar wants to merge 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Primarily a refactor, but it changes CLI argument parsing types and authentication/client initialization paths, which could cause subtle runtime/CLI compatibility issues (e.g., parsing/validation differences and RPC connectivity).
Overview
Switches many CLI commands from manual string parsing to SDK-native clap-parsed types (e.g.
Address,B256,U256) for addresses/condition IDs/token IDs, removingparse_address/parse_condition_idhelpers and consolidating enum conversions via the newenum_from!macro.Centralizes common behavior:
main.rsnow lazily initializes shared SDK clients, errors are printed viaoutput::print_error(used by bothmainandshell), and table output formatting is normalized with shared helpers (NONE,format_date,active_status).Makes a few operational tweaks: Polygon RPC URL can now be overridden via
POLYMARKET_RPC_URL, USDC address is shared asUSDC_ADDRESS_STR, and wallet setup/import now stores a canonical hex key derived from the signer (signer_key_hex) rather than normalizing user input.Written by Cursor Bugbot for commit 7431398. This will update automatically on new commits. Configure here.