New York CTC computation fixes #4451
Conversation
|
Some concerns @PavelMakarchuk
|
|
@Shinuing thank you for looking into this, can we refactor the current code? I know it seems fairly complex but I believe we have missed a portion of the Worksheets |
I can model the worksheet (I don't think we model it at all). |
policyengine_us/parameters/gov/states/ny/tax/income/credits/ctc/amount/match.yaml
Show resolved
Hide resolved
; branch 'Shinuing/issue4427' of https://github.com/Shinuing/policyengine-us into Shinuing/issue4427
policyengine_us/parameters/gov/states/ny/tax/income/credits/ctc/amount/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_c.py
Outdated
Show resolved
Hide resolved
| period: year | ||
| label: NY CTC additional tax credit children amount | ||
| reference: | ||
| - title: Instructions for Form IT-213 Claim for Empire State Child Credit |
There was a problem hiding this comment.
could you add 2021, 2022 , and 2023 tax forms as well as the legal code here?
There was a problem hiding this comment.
could you add 2021, 2022 , and 2023 tax forms as well as the legal code here?
cannot find any limit in the legal code
There was a problem hiding this comment.
Also, starting from 2023, no more min age limitation. And no worksheet B anymore. in this case we may need to create new calculations, please advice
There was a problem hiding this comment.
If there are structural changes for 2023 lets keep this PR to 2021/2022 structure and file a new issue to re-adjust this credit to account for 2023 changes, I would rather make sure that we have modeled the base correctly as it will be easier to add the 2023 conditions afterwards
...engine_us/parameters/gov/states/ny/tax/income/credits/ctc/additional_number_of_children.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_federal_credits.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc_worksheet_b.py
Outdated
Show resolved
Hide resolved
|
Hi @PavelMakarchuk , could you help check the worksheet A,B,C logic before moving forward? Also please advice with the |
PavelMakarchuk
changed the title
| # Line 11 - 4: earned income match | ||
| earned_income_match = ( | ||
| earned_income_adjustment * p.amount.earned_income_match | ||
| ) |
There was a problem hiding this comment.
I have refactored the worksheet computations as they look good to me.
We will fix the Line 11 from Worksheet B in a separate issue #4611 as I would like to merge this for further testing
...variables/gov/states/ny/tax/income/credits/ctc/additional_credit/ny_ctc_additional_credit.py
Outdated
Show resolved
Hide resolved
...variables/gov/states/ny/tax/income/credits/ctc/additional_credit/ny_ctc_additional_credit.py
Outdated
Show resolved
Hide resolved
...variables/gov/states/ny/tax/income/credits/ctc/additional_credit/ny_ctc_additional_credit.py
Outdated
Show resolved
Hide resolved
...ngine_us/parameters/gov/states/ny/tax/income/credits/ctc/earned_income_adjustment/match.yaml
Outdated
Show resolved
Hide resolved
...e_us/parameters/gov/states/ny/tax/income/credits/ctc/earned_income_adjustment/threshold.yaml
Outdated
Show resolved
Hide resolved
…cyengine-us into Shinuing/issue4427
nikhilwoodruff
force-pushed
the
master
branch
2 times, most recently
from
7926ec9 to
d2543dc
Compare
2 participants
try to fix #4427