Adjust the NY Empire State Child Credit to take into account the full ctc amounts

changelog_entry.yaml

@@ -0,0 +1,4 @@
+- bump: minor
+  changes:
+    added:
+    - Adjust the NY Empire State Child Credit to take into account the full ctc amounts.

policyengine_us/tests/policy/baseline/gov/states/ny/tax/income/credits/ny_ctc.yaml

@@ -23,7 +23,7 @@
   output:
     ny_ctc: 0
 
-- name: Parent of four-year old child with no income gets minimum credit
+- name: Parent of four-year old child with no income gets minimum credit, 33% of $1,000
   period: 2022
   input:
     people:
@@ -40,9 +40,9 @@
         members: [parent, child]
         state_code: NY
   output:
-    ny_ctc: 100
+    ny_ctc: 330
 
-- name: Parent of four-year old child with no income gets minimum credit
+- name: Parent of four-year old child with no income gets minimum credit, 33% of $1,000
   period: 2022
   input:
     people:
@@ -59,7 +59,7 @@
         members: [parent, child]
         state_code: NY
   output:
-    ny_ctc: 100
+    ny_ctc: 330
 
 - name: Simpler calculation if not set to pre-TCJA.
   period: 2022

policyengine_us/tests/policy/baseline/gov/states/ny/tax/income/integration.yaml

@@ -0,0 +1,48 @@
+- name: Tax unit with taxsimid 92522 in e21.its.csv and e21.ots.csv
+  absolute_error_margin: 0.01
+  period: 2021
+  input:
+    people:
+      person1:
+        age: 67
+        employment_income: 23010
+        taxable_interest_income: 5505.0
+        ssi: 0  # not in TAXSIM35
+        state_supplement: 0  # not in TAXSIM35
+        wic: 0  # not in TAXSIM35
+        ma_covid_19_essential_employee_premium_pay_program: 0  # not in TAXSIM35
+      person2:
+        age: 67
+        employment_income: 2010
+        taxable_interest_income: 5505.0
+        ssi: 0  # not in TAXSIM35
+        state_supplement: 0  # not in TAXSIM35
+        wic: 0  # not in TAXSIM35
+        ma_covid_19_essential_employee_premium_pay_program: 0  # not in TAXSIM35
+      person3:
+        age: 11
+        ssi: 0  # not in TAXSIM35
+        state_supplement: 0  # not in TAXSIM35
+        wic: 0  # not in TAXSIM35
+        ma_covid_19_essential_employee_premium_pay_program: 0  # not in TAXSIM35
+      person4:
+        age: 11
+      person5:
+        age: 11
+      person6:
+        age: 16
+    tax_units:
+      tax_unit:
+        members: [person1, person2, person3, person4, person5, person6]
+        premium_tax_credit: 0  # not in TAXSIM35
+    spm_units:
+      spm_unit:
+        members: [person1, person2, person3, person4, person5, person6]
+        snap: 0  # not in TAXSIM35
+        tanf: 0  # not in TAXSIM35
+    households:
+      household:
+        members: [person1, person2, person3, person4, person5, person6]
+        state_fips: 36  # NY
+  output:  # expected results from patched TAXSIM35 2024-02-15 version
+    ny_income_tax: -680.80

policyengine_us/variables/gov/states/ny/tax/income/credits/ctc/ny_ctc.py

@@ -52,7 +52,7 @@ def formula(tax_unit, period, parameters):
                 period,
                 maximum_ctc * meets_ny_minimum_age,
             )
-            federal_ctc = pre_tcja_ctc.tax_unit("ctc_value", period)
+            federal_ctc = pre_tcja_ctc.tax_unit("ctc", period)
             qualifies_for_federal_ctc = pre_tcja_ctc.person(
                 "ctc_qualifying_child", period
             )