Refactor #416
Merged
Refactor #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… breaking tests for some reason
MaxGhenis
commented
Dec 26, 2021
nikhilwoodruff
approved these changes
Dec 26, 2021
There was a problem hiding this comment.
Amazing, thanks @MaxGhenis: this is a massive improvement to code readability (for both humans and machines).
| return household("property_purchased", period) * household( | ||
| "main_residence_value", period | ||
| ) | ||
| property_purchased = household("property_purchased", period) |
There was a problem hiding this comment.
Have thought about this - while this is equivalent to before, I think assigning to variables like this to avoid the auto-formatted brackets mess makes the formulas more readable - will do this in future, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change any logic, does a few things:
unitto variablesreturnstatementsfrom openfisca_uk.model_api import *meets_marriage_allowance_income_conditions(I had to debug this one when rewriting)