TextureMapping template is now also defined for PointNormal.

[paperManu]

The pcl::TextureMapping template was only defined for PointXYZ, and some hardcoded types in the implementation prevented the simple instanciation for new point types.

This has been corrected, it is now also instanciated for PointNormal (which has been tested). More types could be added but were not tested.

Also, the TextureMapping::Ptr subtype was refering to shared_ptr, which is not the common thing in PCL. This has been modified so that it now refers to shared_ptr<TextureMapping<...>>, and a new TextureMapping::PointPtr subtype has been added.

[taketwo]

boost::shared_ptr<PointInT> is really useless. Obviously lines 102/103 had a typo in the first place, so no need to keep these pointer-to-point typedefs.

[taketwo]

Great find! I would like to merge this, but please first see the comments I left.

[paperManu]

OK I'm doing the suggested correction. Should I add some other point types, like PointXYZRGBNormal, PointXYZRGB, PointXYZRGBA ?

[taketwo]

It's common to have two branches, one with a minimalistic set of types, and the other "all-inclusive". Something like:

#ifdef PCL_ONLY_CORE_POINT_TYPES
  PCL_INSTANTIATE(TextureMapping, (pcl::PointXYZ))
#else
  PCL_INSTANTIATE(TextureMapping, (PCL_XYZ_POINT_TYPES))
#endif

[paperManu]

Done!

[taketwo]

Can you please squash the commits into one? (Have a look at git rebase -i.)

[paperManu]

Hum, is it possible to do this without creating a new branch?

[VictorLamoine]

Yes it is possible, follow the instructions given at taketwo's link! In short:
Switch to your local texture_mapping branch:
$ git checkout texture_mapping
$ git rebase -i

At this point you will see a list of 2 commits (read the comments at the end)
Replace pick of the last commit by s (squash)
Then do Ctrl + X and save the modifications.
The 2 commits have been merged into a single commit.

To push the modifications do a
$ git push -f origin texture_mapping

You need to specify the -f option to override the first commit.
Go back here and the pull request has been updated 😄

[paperManu]

I see, I thought forcing the push could do some nasty things ;)

[taketwo]

Yes, generally force pushing should be avoided because it changes (already public) history. In case of a pull request, however, the history is not important. What is important is that we have a clean history once it's merged :)

Thanks for the contribution!