Add const "guards" in correspondence estimation #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add const keyword to function parameters which are not meant to be modified inside the function in correspondence estimation classes * Add const keyword to local variables which are not meant to be modified in correspondence estimation classes except for variables in clone() functions Signed-off-by: Ramir Sultanov <sumir0@proton.me>
sumir0
force-pushed
the
correspondence-estimation-with-some-const-guards
branch
from
7b7e02c to
ecb2a96
Compare
|
I am sorry for the force-push after opening the pull request. Let's wait for the pipeline to finish. After that the changes can be reviewed I think. |
larshg
approved these changes
Sep 24, 2025
larshg
added
module: registration
changelog: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add const keyword to function parameters which are not meant to be modified inside the function in correspondence estimation classes
Add const keyword to local variables which are not meant to be modified in correspondence estimation classes except for variables in clone() functions
Background
I was looking into #329, #4901, and other when noticed some variables and parameters not being
const. So I decided to "improve" the code when I had an opportunity.Variables in
clone()functionsI didn't change constness of variable
copyinclone()functions because I am just unsure about NRVO in this case. Maybe I should have addedconstin these cases. But that can be done later anyway.About
constfunction parameters passed by valueThere are multiple opinions on the usage of
constwith function parameters passed by value in the C++ community. I usedconstwith function parameters in this pull request to prevent mistakes when a parameter is modified inside the function but should not be. We can discuss it andconstin function declarations and etc. further if you need or want to.P.S.
I also noticed other non-critical things but, probably, I should try to prioritize tasks to do more important contributions.