Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sure point is finite before vicinity search #617

Merged
merged 1 commit into from
Apr 7, 2014

Conversation

nizar-sallem
Copy link
Contributor

There is no test ensure that the point is valid before vicinity search.

taketwo added a commit that referenced this pull request Apr 7, 2014
Fix: make sure point is finite before vicinity search
@taketwo taketwo merged commit 1b58c8b into PointCloudLibrary:master Apr 7, 2014
@taketwo
Copy link
Member

taketwo commented Apr 7, 2014

I think it's quite a common pattern to check if a cloud is dense and then have two branches, one with isFinite tests and the other without. Besides this test the code is often the same (i.e. copy-pasted). Perhaps we could introduce some sort of "finite point iterator" to iterate over a cloud. When the cloud is dense this is just a normal iterator, when the cloud is not dense, it incorporates the test. Will put this idea in my todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants