-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use emplace_back
instead of push_back
#6127
Conversation
Yes, its our code format that rejects it. So you need to remove the spaces. Its however not all files that are checked yet by the formatter, hence some files you can still leave them as is, but preferably correct them all places. |
You can use the patch generated here: https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=24754&view=artifacts&pathAsName=false&type=publishedArtifacts |
Thanks, I shall correct them in all places |
@DIlkhush00 There are unfortunately still a few formatting issues left, see: https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=24755&view=logs&j=84ba2080-ade3-55e3-f209-94ce73f9d406&t=9838d42f-a715-5615-242f-7e73bf03078b (so just a different indentation) |
Fixed. I hope everything's good now 🙂 |
a650596
to
2debe4e
Compare
Looks good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.