Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use emplace_back instead of push_back #6127

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

DIlkhush00
Copy link
Contributor

No description provided.

@DIlkhush00
Copy link
Contributor Author

@larshg @mvieth , I am not sure but did the build fail because of the spacing between the emplace_back and it's opening bracket ( ?

@larshg
Copy link
Contributor

larshg commented Sep 9, 2024

@larshg @mvieth , I am not sure but did the build fail because of the spacing between the emplace_back and it's opening bracket ( ?

Yes, its our code format that rejects it. So you need to remove the spaces.

Its however not all files that are checked yet by the formatter, hence some files you can still leave them as is, but preferably correct them all places.

@larshg
Copy link
Contributor

larshg commented Sep 9, 2024

@DIlkhush00
Copy link
Contributor Author

Thanks, I shall correct them in all places

@mvieth
Copy link
Member

mvieth commented Sep 9, 2024

@DIlkhush00 There are unfortunately still a few formatting issues left, see: https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=24755&view=logs&j=84ba2080-ade3-55e3-f209-94ce73f9d406&t=9838d42f-a715-5615-242f-7e73bf03078b (so just a different indentation)

@DIlkhush00
Copy link
Contributor Author

Fixed. I hope everything's good now 🙂

@larshg
Copy link
Contributor

larshg commented Sep 9, 2024

Looks good 👍

Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvieth mvieth merged commit e81b3a7 into PointCloudLibrary:master Sep 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants