Skip to content

Add: filter to remove locally maximal points in the z dimension#577

Merged
taketwo merged 1 commit intoPointCloudLibrary:masterfrom
chambbj:filter-local-max
Mar 26, 2014
Merged

Add: filter to remove locally maximal points in the z dimension#577
taketwo merged 1 commit intoPointCloudLibrary:masterfrom
chambbj:filter-local-max

Conversation

@chambbj
Copy link
Contributor

@chambbj chambbj commented Mar 18, 2014

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates (and hides) the same function in FilterIndices. Any reason for having this (and getNegative)?

@chambbj
Copy link
Contributor Author

chambbj commented Mar 25, 2014

@taketwo I've made the requested changes. Looks like Travis should pass as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space here. And since you anyway will modify the line, we cloud change int to size_t to avoid compiler warnings.

@taketwo
Copy link
Member

taketwo commented Mar 26, 2014

I guess the algorithm may be accelerated quite a bit. Whenever you find a point that is the local maximum, you can safely exclude all of its neighbors from the processing queue because they are guaranteed not to be maximum in their region. That will save a number of radius searches.

But that's more of a loud thinking. I think we could merge as is.

@chambbj
Copy link
Contributor Author

chambbj commented Mar 26, 2014

It's a good thought and doesn't seem like a lot of work. Since I've got another update to make as it is, I'll go ahead and investigate this.

@chambbj
Copy link
Contributor Author

chambbj commented Mar 26, 2014

@taketwo Just pushed the update to this one. Take a look when you get a chance.

taketwo added a commit that referenced this pull request Mar 26, 2014
Add: filter to remove locally maximal points in the z dimension
@taketwo taketwo merged commit 646904a into PointCloudLibrary:master Mar 26, 2014
@taketwo
Copy link
Member

taketwo commented Mar 26, 2014

Great, thank you!

@chambbj chambbj deleted the filter-local-max branch March 26, 2014 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants