Fix CropHull::applyFilter3D() #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CropHull::applyFilter3D() when crop_outside_ is false and add back test_crop_inside for 3D
|
Just found #1657. This resolves it. |
yasamoka
force-pushed
the
crop-hull-crop-inside-fix
branch
from
4804541
to
c3a5f34
Compare
|
Sorry, the force push was to revert changes made to this branch by mistake while they were intended for another branch. The branch is now back to how it was before. |
mvieth
added
module: filters
changelog: fix
larshg
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CropHull::applyFilter3D() when
crop_outside_is set to false and adds backtest_crop_insidefor 3D cases.Previously:
Meaning that when
crop_outside_was set to false, all the points in the input point cloud would be kept regardless, which is not the expected behavior.