Update pcl_find_boost to allow compilation with Boost 1.73 and 1.72

[UnaNancyOwen]

Add 1.72.0 and 1.73.0

[jspricke]

Is this necessary, still? (just asking)

[UnaNancyOwen]

@jspricke Yes, it is necessary when users are using an older version of CMake that can't find newer version of Boost by default. Users aren't always using a latest version of CMake.

[jspricke]

Maybe we should increase the required cmake version instead, do you know which version would be needed?

[jspricke]

Looking through my FindBoost.cmake, I guess there should be a version locking between the file and the installed boost version. So this seems like a okish workaround..

[SergioRAgostinho]

We're bumping to 3.10 very soon.

[SunBlack]

Switching to a newer CMake version doesn't change anything, as they didn't have changed there anything. So In case you want to use e.g. Boost 1.72 with CMake 3.10 it is still not possible, as long we use FindBoost of CMake. So by updating Boost_ADDITIONAL_VERSIONS we tell CMake: We don't care if you don't know the new version, as we checked it manually that no required module is gone and we don't need a new module of Boost.

We could only try to force config mode by find_package(Boost CONFIG), so we don't need this list anymore - but I think there is a reason why CMake still updates their find script instead of to deprecate it and say: use the config. But no idea why.

[OgreTransporter]

FYI: Using boost 1.74:

10>D:\test\PCL\deps\boost\install\boost/function_output_iterator.hpp(14): note: This header is deprecated. Use <boost/iterator/function_output_iterator.hpp> instead.

[kunaltyagi]

1.74 isn't released yet: https://www.boost.org/users/history/

But once it is, we'll have to make some changes

[OgreTransporter]

It's just a warning. The old header is still there and still works. Does the new header already exist under 1.72/1.73?

The release date of 1.74 is set to 12. Aug. 2020.

[kunaltyagi]

Does the new header already exist under 1.72/1.73

In 1.72 it does. But not in 1.65 (18.04) so we'd need a patch sometime later

[srini196]

Has the All-In-One Windows installer been updated to support compilation with Boost1.74?

[kunaltyagi]

Unless @UnaNancyOwen took steps to include the patch from #4330, no. You should be able to manually apply the required patch if needed

[UnaNancyOwen]

@srini196 PCL 1.11.1 All-in-one Installer is built with Boost 1.74.0 (backported #4330). You can use Boost 1.74.0. For more information, Please see my build notes.

[OgreTransporter]

For information only: On next Wednesday boost 1.75 will be published. FindBoost from CMake does not work with this version!

[kunaltyagi]

I really don't love this part of CMake 😆