Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error: misplaced deprecation attributes in vtkVertexBufferObject{,Mapper} #4079

Merged
merged 1 commit into from
May 11, 2020

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented May 11, 2020

Fixes an issue introduced in #4065. Didn't saw it earlier as gcc8 doesn't complain and my Clang 10 build is still broken.

/home/sunblack/dev/pcl/visualization/include/pcl/visualization/vtk/vtkVertexBufferObjectMapper.h:39:6: error: misplaced attributes; expected attributes here
class PCL_EXPORTS vtkVertexBufferObjectMapper : public vtkMapper
     ^
     PCL_DEPRECATED(1, 13, "The OpenGL backend of VTK is deprecated. Please switch to the OpenGL2 backend.")

Note: Running clang-format will be fun for this:

class PCL_DEPRECATED(
    1,
    13,
    "The OpenGL backend of VTK is deprecated. Please switch to the OpenGL2 backend.")
    PCL_EXPORTS vtkVertexBufferObject : public vtkObject {

@SergioRAgostinho
Copy link
Member

This highlights one of the stages we forgot in the release cycle. A release candidate :)

@SunBlack
Copy link
Contributor Author

Interesting thing: MSVC complains it like Clang 10. Sad GCC doesn't :-(

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: visualization labels May 11, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.11.1 milestone May 11, 2020
@kunaltyagi kunaltyagi changed the title Fix error: misplaced attributes in vtkVertexBufferObjectMapper and vtkVertexBufferObject Fix error: misplaced deprecation attributes in vtkVertexBufferObject{,Mapper} May 11, 2020
@kunaltyagi kunaltyagi merged commit 666baef into PointCloudLibrary:master May 11, 2020
@SunBlack SunBlack deleted the misplaced_attributes branch May 11, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants