Skip to content

Conversation

@kunaltyagi
Copy link
Member

Closes #3661

New features in 1.11:

  • Shift to std::shared_ptr from boost::shared_ptr
  • Added pcl::index_t in anticipation of adding support for very-large point-clouds
  • Deprecation warnings inform users how long the feature will be supported
  • All this on the side of the usual bug fixes and algorithm improvements. For more details, please check the changelog

Checklist:

  • CI are not red
  • Milestone list has no actionable items that can't make it to 1.11.1

TODO (not in this PR):

  • Release with Changelog
  • Upload code
  • Bump version again

@kunaltyagi kunaltyagi added this to the pcl-1.11.0 milestone May 9, 2020
@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation needs: code review Specify why not closed/merged yet labels May 9, 2020
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11.0

That or fix all the issues with the absence of patch version.

@kunaltyagi
Copy link
Member Author

Oops

@taketwo
Copy link
Member

taketwo commented May 10, 2020

Sorry, it's me with labeling again. How is this changelog: fix? The idea of the changelog is to give a user of the library an idea of what has changed, what to expect from the release. "Bump version for release" is not an addition or a change in the library.

On the topic of this PR, we usually include changelog update in the "bump version" PR (otherwise this would need to be a separate one). However, before you do that, I need to go through the auto-generated changelog and check the items there, I suspect there might be a lot of noise that does not belong to the release changelog.

@kunaltyagi
Copy link
Member Author

I noticed it doesn't get added to changelog (if you ignore the last misc PR section but that's due to my changelog generation command) provided there's no module attached, so I thought why not add fix since it removes an issue.

That's about it.

@taketwo
Copy link
Member

taketwo commented May 10, 2020

I thought why not add fix since it removes an issue.

Please don't abuse changelog: fix for that. Every time you consider tagging with a label from changelog: xxx group, try to say it loud:

"This PR is a fix/enhancement that the library users should be aware of. Append the title of this PR to the release changelog."

@kunaltyagi kunaltyagi removed the changelog: fix Meta-information for changelog generation label May 10, 2020
@taketwo
Copy link
Member

taketwo commented May 10, 2020

Done with the clean-up, please add changelog to this PR.

By the way, is there a date for the release?

@kunaltyagi
Copy link
Member Author

I planned for the weekend release. Today (2020-05-11) is as fine a day as any.

Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2020-05-11 09-39-14

If a particular PR appears in the API changes it no longer makes sense to have it in the ABI changes. #3626 violates that premise.

Other than that, it's a very pleasant changelog to read. Good job guys.

@taketwo
Copy link
Member

taketwo commented May 11, 2020

If a particular PR appears in the API changes it no longer makes sense to have it in the ABI changes.

Makes sense. Would you address this at the generator script level or during tagging (i.e. take care not to set both labels)?

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented May 11, 2020

Generator level, printing a warning at the end listing all PRs which violate that premise.

Enforcing algorithm behavior is (in general) easier than enforcing human behavior :)

@kunaltyagi
Copy link
Member Author

Fixed the issue with a commit. Will keep in mind while tagging from now on

@kunaltyagi
Copy link
Member Author

Merging because there's no actionable item left (the CI was already green)

@kunaltyagi kunaltyagi merged commit f9f214f into PointCloudLibrary:master May 11, 2020
@kunaltyagi kunaltyagi deleted the 1.11 branch May 11, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: code review Specify why not closed/merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.11.0 Release

3 participants