-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Bump version for release #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version for release #4075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.11.0
That or fix all the issues with the absence of patch version.
|
Oops |
|
Sorry, it's me with labeling again. How is this On the topic of this PR, we usually include changelog update in the "bump version" PR (otherwise this would need to be a separate one). However, before you do that, I need to go through the auto-generated changelog and check the items there, I suspect there might be a lot of noise that does not belong to the release changelog. |
|
I noticed it doesn't get added to changelog (if you ignore the last misc PR section but that's due to my changelog generation command) provided there's no module attached, so I thought why not add That's about it. |
Please don't abuse "This PR is a fix/enhancement that the library users should be aware of. Append the title of this PR to the release changelog." |
|
Done with the clean-up, please add changelog to this PR. By the way, is there a date for the release? |
|
I planned for the weekend release. Today (2020-05-11) is as fine a day as any. |
SergioRAgostinho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a particular PR appears in the API changes it no longer makes sense to have it in the ABI changes. #3626 violates that premise.
Other than that, it's a very pleasant changelog to read. Good job guys.
Makes sense. Would you address this at the generator script level or during tagging (i.e. take care not to set both labels)? |
|
Generator level, printing a warning at the end listing all PRs which violate that premise. Enforcing algorithm behavior is (in general) easier than enforcing human behavior :) |
|
Fixed the issue with a commit. Will keep in mind while tagging from now on |
|
Merging because there's no actionable item left (the CI was already green) |

Closes #3661
New features in 1.11:
std::shared_ptrfromboost::shared_ptrpcl::index_tin anticipation of adding support for very-large point-cloudsChecklist:
TODO (not in this PR):