-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert boost::shared_ptr
to pcl::shared_ptr
#3546
Conversation
Feel free to close without merge (based on previous discussions) |
44cc8a9
to
0bd9019
Compare
7275130
to
76b3ef9
Compare
Do you think this is ready for merging? Could you perhaps write up some explanation (for the changelog) what the users are supposed to do with this class? |
With Starting with PCL 1.10, to ensure compatibility with future PCL releases, please use In my other projects, I actually use this abstraction (which needs explicit knowledge). I might improve that abstraction further actually. |
Thanks for the blurb, will integrate it into the changelog. Can you please squash formatter changes into commits? I'd like to merge soon and finally release 1.10 this weekend. |
Sure. I'll send the changes in a few hours. Sorry for the delay |
76b3ef9
to
5b7a4be
Compare
5b7a4be
to
8259d96
Compare
pcl::shared_ptr
boost::shared_ptr
topcl::shared_ptr
This PR will allow for 2 PCL releases: 1.10 (with boost::shared_ptr) and 1.11 (with std::shared_ptr) with just 1 commit in the changelog.
Results achieved by: