Restructure and add functionality to PCLPointCloud2 filters Par… #3500
Conversation
mvieth
commented
Dec 6, 2019
mvieth
commented
- replace two applyFilter(indices) functions
- previously, the functions did not consider removed_indices_ and extract_removed_indices_
- applyFilter(indices) in RandomSample previously also did not consider negative_
- adapted code from the templated filters (hpp files) was used
- follow-up to pr Restructure and add functionality to PCLPointCloud2 filters #3483, see also issue Bug in CropBox regarding keep organized? #3471
|
The check in RandomSample fails because it is tested whether the two filter functions (the one that takes a cloud and the one that takes indices) do the same thing, which (with this commit) they don't. My plan was to create another PR later with this commit which makes the |
There was a problem hiding this comment.
Hi, sorry for the delay.
My plan was to create another PR later with this commit
I certainly don't like the idea of merging a PR that breaks CI. So we either 1) disable the tests in question is this PR and re-enable later, or 2) add the said commit to this PR. I prefer the second option as it does not reduce test coverage in the progress and the commit is closely related anyway.
- previously, the functions did not consider removed_indices_ and extract_removed_indices_ - applyFilter(indices) in RandomSample previously also did not consider negative_ - adapted code from the templated filters (hpp files) was used
…, and RandomSample - for CropBox and RandomSample the applyFilter(cloud)-functions were replaced with adapted code from the templated filters (hpp files) - for RadiusOutlierRemoval, the existing applyFilter(cloud)-function was only slightly changed
|
Let's merge this? |
taketwo
changed the title
