Apply clang-format to 2d module #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
kunaltyagi
reviewed
Sep 13, 2019
2d/include/pcl/2d/impl/edge.hpp
Outdated
| cannyTraceEdge (-1, 1, i, j, *maxima); | ||
| cannyTraceEdge ( 1, -1, i, j, *maxima); | ||
| (*maxima)(j, i).intensity = std::numeric_limits<float>::max(); | ||
| cannyTraceEdge(1, 0, i, j, *maxima); |
There was a problem hiding this comment.
This might be one of the places to disable clang-format for the table like manual formatting
kunaltyagi
reviewed
Sep 13, 2019
2d/include/pcl/2d/impl/kernel.hpp
Outdated
| break; | ||
| } | ||
| switch (kernel_type_) { | ||
| case SOBEL_X: { |
There was a problem hiding this comment.
Are the brackets even required? Seems like just a fn call with break
|
For formatting docstrings, I highly suggest the use of doxydoxygen to autoformat them. You can simply do alt+q instead of manually formatting them. |
|
@jasjuang thanks for the tip, the tool looks very useful. It's a pity that it's Sublime-only and they don't provide it in a "library" format for easy integration with other editors :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first pass of clang-format some of the docstrings were screwed up (different
\paramlines joined). Therefore, I needed to apply some manual docstring formatting here and there and then run clang-format again to reach equilibrium.