Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[io] Suppress fallthrough warnings #3342

Merged

Conversation

SergioRAgostinho
Copy link
Member

$ ninja  pcl_io                                                                                                    
[15/62] Building CXX object io/CMakeFiles/pcl_io.dir/src/lzf.cpp.o                                                                                                
../io/src/lzf.cpp: In function ‘unsigned int pcl::lzfDecompress(const void*, unsigned int, void*, unsigned int)’:                                                 
../io/src/lzf.cpp:309:24: warning: this statement may fall through [-Wimplicit-fallthrough=]                                                                      
         case 32: *op++ = *ip++; case 31: *op++ = *ip++; case 30: *op++ = *ip++; case 29: *op++ = *ip++;                                                          
                  ~~~~~~^~~~~~~                                                                                                                                   
../io/src/lzf.cpp:309:33: note: here                                                                                                                              
         case 32: *op++ = *ip++; case 31: *op++ = *ip++; case 30: *op++ = *ip++; case 29: *op++ = *ip++;                                                          
                                 ^~~~                                                                                                                             
../io/src/lzf.cpp:309:48: warning: this statement may fall through [-Wimplicit-fallthrough=]                                                                      
         case 32: *op++ = *ip++; case 31: *op++ = *ip++; case 30: *op++ = *ip++; case 29: *op++ = *ip++;                                                          
                                          ~~~~~~^~~~~~~                                                 

Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My God 😆

@taketwo taketwo merged commit 2468214 into PointCloudLibrary:master Sep 13, 2019
@SergioRAgostinho SergioRAgostinho deleted the implicit-fallthrough branch September 13, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants