Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove else after return statement [2d, apps, common, cuda, examples, features, filters, geometry, gpu] #3180

Conversation

SunBlack
Copy link
Contributor

Changes are done by: run-clang-tidy -header-filter='.' -checks='-,readability-else-after-return' -fix

@taketwo taketwo added the needs: more work Specify why not closed/merged yet label Jun 21, 2019
@SunBlack SunBlack force-pushed the readability-else-after-return_2d-gpu branch 3 times, most recently from 93c01ed to c7cbdb6 Compare June 25, 2019 13:04
@SunBlack
Copy link
Contributor Author

SunBlack commented Jul 4, 2019

Just to mention: MSVC build works on my PC. So seems to be Azure had trouble.

@taketwo taketwo removed the needs: more work Specify why not closed/merged yet label Jul 4, 2019
@taketwo
Copy link
Member

taketwo commented Jul 4, 2019

Right, it's this LZ4 issue. Can you rebase on current master please? Sergio has just merged a fix.

@SunBlack SunBlack force-pushed the readability-else-after-return_2d-gpu branch from c7cbdb6 to 74cf3bd Compare July 6, 2019 12:17
@taketwo taketwo merged commit beb5ead into PointCloudLibrary:master Jul 14, 2019
@SunBlack SunBlack deleted the readability-else-after-return_2d-gpu branch July 14, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants