Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer std::isnan over != comparison trick #2977

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Prefer std::isnan over != comparison trick #2977

merged 1 commit into from
Apr 7, 2019

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Apr 7, 2019

Fixes #2974.

@SergioRAgostinho SergioRAgostinho merged commit 7844254 into PointCloudLibrary:master Apr 7, 2019
@taketwo taketwo deleted the fix-2974 branch April 8, 2019 09:16
@taketwo taketwo added the c++14 label Jan 14, 2020
@taketwo taketwo changed the title Use std::isnan instead of != comparison trick Prefer std::isnan over != comparison trick Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about source code: if (cos_angle != cos_angle)
2 participants
@taketwo @SergioRAgostinho