Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring of pcl::visualization::Camera and related functions #2901

Merged
merged 4 commits into from
Mar 12, 2019
Merged

Minor refactoring of pcl::visualization::Camera and related functions #2901

merged 4 commits into from
Mar 12, 2019

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Mar 10, 2019

  • Add default constructor for the camera
  • Add constructors from VTK objects for the camera
  • Remove reference in PCLVisualizer::setupCamera signature
  • Add viewport parameter with default value to getCameraParameters methods

@taketwo taketwo added changelog: API break Meta-information for changelog generation module: visualization labels Mar 10, 2019
SergioRAgostinho
SergioRAgostinho reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comment. You're definitely breaking the ABI with this PR, but I'm failing to see the API breakage. You've added default parameters in all methods you've changed the signature and the methods you've made const are not virtual, so it should be a safe transition no?

visualization/include/pcl/visualization/common/common.h Show resolved Hide resolved
visualization/include/pcl/visualization/common/common.h Show resolved Hide resolved
visualization/include/pcl/visualization/common/common.h Show resolved Hide resolved
visualization/src/interactor_style.cpp Outdated Show resolved Hide resolved
@taketwo
Add default constructor for pcl::visualization::Camera
8c2430c 
Initializes parameters with reasonable default values. The values were copied over from pcl::visualization::PCLVisualizer::initCameraParameters().
@taketwo
Add constructors from VTK objects for pcl::vsualization::Camera
26ef1d2 
This commit also updates code to use the new constructors.
@taketwo
Change signature of PCLVisualizer::setupCamera()
dead2c4 
argc parameter does not to be a reference. Also improves function documentation.
@taketwo
Add viewport parameter in getCameraParameters() functions
336993e
@SergioRAgostinho
Copy link
Member

You're definitely breaking the ABI with this PR, but I'm failing to see the API breakage. You've added default parameters in all methods you've changed the signature and the methods you've made const are not virtual, so it should be a safe transition no?

@taketwo Any comment on this? Where are you noticing API breakage?

@taketwo
Copy link
Member Author

taketwo commented Mar 12, 2019

Sorry, missed this question. Yes, this should be a safe transition, certainly not "API breakage". Rather "API change" but we don't have such a label (and probably don't need anyway).

@taketwo taketwo removed the changelog: API break Meta-information for changelog generation label Mar 12, 2019
@SergioRAgostinho SergioRAgostinho added the changelog: ABI break Meta-information for changelog generation label Mar 12, 2019
@SergioRAgostinho SergioRAgostinho merged commit 5237f12 into PointCloudLibrary:master Mar 12, 2019
@taketwo taketwo deleted the minor-camera-refactoring branch March 12, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
changelog: ABI break Meta-information for changelog generation module: visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taketwo @SergioRAgostinho