Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform classic loops to range-based for loops in tests. #2851

Merged

Conversation

SunBlack
Copy link
Contributor

Includes small changes to person_cluster (add const to some getter).

Changes are based on the result of run-clang-tidy -header-filter='.' -checks='-,modernize-loop-convert' -fix

@SunBlack SunBlack force-pushed the range_based_loops_tests branch 2 times, most recently from 78eb17b to 0c16593 Compare February 11, 2019 11:00
@SergioRAgostinho
Copy link
Member

Includes small changes to person_cluster (add const to some getter).

Ideally it should be on a separate PR, but let's do it at least on a separate commit.

Heiko Thiel added 3 commits March 11, 2019 17:19
Changes are based on the result of run-clang-tidy -header-filter='.*' -checks='-*,modernize-loop-convert' -fix
@SunBlack SunBlack force-pushed the range_based_loops_tests branch from 93c0992 to dc346da Compare March 11, 2019 16:30
@SunBlack
Copy link
Contributor Author

Commit splitted.

Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@SergioRAgostinho SergioRAgostinho merged commit 986a373 into PointCloudLibrary:master Mar 13, 2019
@SunBlack SunBlack deleted the range_based_loops_tests branch March 13, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants