Transition to standard smart pointers, part 3 #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@SergioRAgostinho if you prefer, I may put this commit in a separate PR so that we don't need to mark with whole thing with "deprecation" label.
I was trying to see if I could spare you from that trouble, but it's undoubtedly better to do so.
doc/tutorials/content/sources/ensenso_cameras/ensenso_cloud_images_viewer.cpp
Show resolved
Hide resolved
|
OK, will split and update this one later today. |
taketwo
force-pushed
the
smart-pointers-3
branch
from
35cf391
to
0ff64eb
Compare
SergioRAgostinho
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2792.
Note the deprecation in the second commit. The reason is that when the shared pointer is used through a
typedef, compiler has difficulties determining the template type. Thus the template types should be explicitly specified when usingcomputeRSD. But, this is not needed if there are no pointers at all.@SergioRAgostinho if you prefer, I may put this commit in a separate PR so that we don't need to mark with whole thing with "deprecation" label.