Use range-based loop in ORROctreeZProjection::build #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunBlack
force-pushed
the
ORROctreeZProjection_build_range_based_loop
branch
from
79725ec
to
5636d0b
Compare
taketwo
approved these changes
Jan 30, 2019
|
I need to rebase this or the other, because they are touching same lines. So it doesn't matter. |
|
As per @SergioRAgostinho's request, please do not rebase (this modifies them) the already reviewed commits in #2807. |
SergioRAgostinho
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short explanation:
full_leaves_boundswill be initialized to values, so during first loop run these values will be always overridden by value of first leave. This are 4 additional assignments of double, but it increases readability due to range-based for loop