Drop CUDA 7.0 (and below) support #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunBlack
force-pushed
the
raise_minimum_cuda_version
branch
from
cc16f25
to
bbafa9d
Compare
…upport C++14 compilers. Includes deprecation warning fixes.
SunBlack
force-pushed
the
raise_minimum_cuda_version
branch
from
bbafa9d
to
4e06711
Compare
SunBlack
changed the title
taketwo
approved these changes
Dec 22, 2018
SergioRAgostinho
approved these changes
Jan 13, 2019
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With C++14 we need at minimum GCC 4.9/5. Support of GCC 4.9 was added in CUDA 7.0. So CUDA 6.5 and below won't work anymore, so removed support of it.
This PR includes some deprecation warning fixes related to CUDA.
//EDIT: In case we require at minimum GCC 5.x we could drop support of CUDA 7.0, too (=> 7.5 as minimum).
//EDIT2: Changed minimum required version to 7.5, because I believe we will require more C++14 features than GCC 4.9 supports (and Ubuntu 16.04 ships 7.5 via apt-get ;) ).