Fix MSVC compile issues in CloudComposer app #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
reviewed
Dec 13, 2018
There was a problem hiding this comment.
Hi, thanks. Generally I'm ok if a PR contains minor style changes or refactorings in addition to the "main" topic. However it's better if they are at least split into separate commits. It seems like this time a bunch of unrelated changes got mixed in a single commit.
If the Windows build is now fixed, can we enable CloudComposer on Azure?
I don't know: See your own reason why this is not build on Azure (#2618 (comment)) |
|
Ah right, thanks for the heads-up. We can enable this when (if) we switch to container-based Windows builds. |
SunBlack
force-pushed
the
fix_cloud_composer_msvc_compiler_issues
branch
from
2aab148
to
a59ede7
Compare
…cc_tool_interface as static library, because current PCL_EXPORTS macro doesn't work with classes using Q_OBJECT.
SunBlack
force-pushed
the
fix_cloud_composer_msvc_compiler_issues
branch
from
a59ede7
to
2b1db9e
Compare
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MSVC compile issues in CloudComposer. This required to build pcl_cc_tool_interface as static library, because current PCL_EXPORTS macro doesn't work with classes using Q_OBJECT (see #2708).
cloud_composer is now using pcl_cc_tool_interface to prevent some cpps need to be compiled for both.