Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax threshold in Hough3DGrouping test #2507

Merged
merged 2 commits into from
Oct 7, 2018
Merged

Relax threshold in Hough3DGrouping test #2507

merged 2 commits into from
Oct 7, 2018

Conversation

SergioRAgostinho
Copy link
Member

@SergioRAgostinho SergioRAgostinho commented Oct 1, 2018 •
edited
Loading

From looking at the code, there might be a chance that the hough threshold is being set too tight. Since this only fails every now and then in the AppVeyor CI, there's a chance that this should be enough to solve the issue.

If not, then I'll fire up the VM.

@SergioRAgostinho SergioRAgostinho added this to the pcl-1.9.0 milestone Oct 1, 2018
@SergioRAgostinho SergioRAgostinho force-pushed the hough-3d branch 3 times, most recently from 1368357 to 20a84d0 Compare October 3, 2018 19:31
@taketwo taketwo merged commit 528da7f into PointCloudLibrary:master Oct 7, 2018
@SergioRAgostinho SergioRAgostinho deleted the hough-3d branch October 9, 2018 09:14
@SergioRAgostinho
Copy link
Member Author

SergioRAgostinho commented Oct 11, 2018 •
edited
Loading

Still not fixed: https://ci.appveyor.com/project/PointCloudLibrary/pcl/builds/19412808/job/xdai9qemwjndqaes#L7258

@SergioRAgostinho SergioRAgostinho mentioned this pull request Oct 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module: recognition module: test
Projects
None yet
Milestone
pcl-1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioRAgostinho @taketwo