Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing const specifier for getters in PCLBase. #2502

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Add missing const specifier for getters in PCLBase. #2502

merged 1 commit into from
Oct 5, 2018

Conversation

csukuangfj
Copy link
Contributor

Fix #2501.

@SergioRAgostinho
Copy link
Member

Small request since you're actively pushing a lot of fixes: it is more meaningful for us to have commit messages like the messages you use when describing the issue. In this case

Added missing const specifier for getters in PCLBase

Fixes issue #2501

I'm reusing the same title from the issue.

From now on please adopt this practice.

@csukuangfj csukuangfj changed the title fix issue #2501. Add missing const specifier for getters in PCLBase. Oct 1, 2018
@csukuangfj
Copy link
Contributor Author

@SergioRAgostinho
all have been fixed.

@SergioRAgostinho SergioRAgostinho merged commit 3682b68 into PointCloudLibrary:master Oct 5, 2018
@csukuangfj csukuangfj deleted the fix-2501 branch October 6, 2018 12:28
@taketwo taketwo changed the title Add missing const specifier for getters in PCLBase. Add missing const specifier for getters in PCLBase. Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants