mesh_sampling tool: Add support for colors - #2257
Merged
Merged
Conversation
taketwo
reviewed
Mar 20, 2018
taketwo
left a comment
taketwo
left a comment
Member
There was a problem hiding this comment.
Besides from inline comments, LGTM.
|
|
||
| inline void | ||
| randPSurface (vtkPolyData * polydata, std::vector<double> * cumulativeAreas, double totalArea, Eigen::Vector4f& p, bool calcNormal, Eigen::Vector3f& n) | ||
| randomPointTriangle (float a1, float a2, float a3, float b1, float b2, float b3, float c1, float c2, float c3, |
Member
There was a problem hiding this comment.
Why do we need this overload? (see next comment)
| Eigen::Vector4f p; | ||
| Eigen::Vector3f n; | ||
| randPSurface (polydata, &cumulativeAreas, totalArea, p, calc_normal, n); | ||
| Eigen::Vector3i c; |
Member
There was a problem hiding this comment.
This can as well be Eigen::Vector4f c, which can be passed directly to the existing version of randomPointTriangle().
taketwo
added
needs: author reply
Contributor
Author
|
@taketwo : I've updated the PR according to your comments. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.