doc: misc. typos - #2213
Merged
SergioRAgostinho merged 3 commits intoFeb 13, 2018
Merged
Conversation
Found via `codespell -q 3`
luzpaz
commented
Feb 13, 2018
| .. important:: | ||
|
|
||
| By default, the algorithm will use a special tranform compressing the depth in Z if your input cloud is organized (eg, from an RGBD sensor like the Kinect). You MUST set use_transform to false if you are using an organized cloud which doesn't have the camera at (0,0,0) and depth in positive Z. The transform is specifically designed to help improve Kinect data by increasing voxel bin size as distance from the camera increases. If your cloud is unorganized, this transform will not be used by default, but can be enabled by using setUseSingleCameraTransform(true). | ||
| By default, the algorithm will use a special transform compressing the depth in Z if your input cloud is organized (eg, from an RGBD sensor like the Kinect). You MUST set use_transform to false if you are using an organized cloud which doesn't have the camera at (0,0,0) and depth in positive Z. The transform is specifically designed to help improve Kinect data by increasing voxel bin size as distance from the camera increases. If your cloud is unorganized, this transform will not be used by default, but can be enabled by using setUseSingleCameraTransform(true). |
Contributor
Author
There was a problem hiding this comment.
the changed word here is s/tranform/transform/
(not sure why github does such a poor job of diffing in these cases.)
SergioRAgostinho
approved these changes
Feb 13, 2018
SergioRAgostinho
left a comment
SergioRAgostinho
left a comment
Member
There was a problem hiding this comment.
Thanks. I highlighted two extra places which need tweaking.
| float and x,y,z,roll,pitch,yaw to describe the local coordinate frame at which | ||
| the feature was extracted. The descriptors can now be compared, e.g., whith the | ||
| the feature was extracted. The descriptors can now be compared, e.g., with the | ||
| Manhatten distance (sum of absolute differences). |
Member
There was a problem hiding this comment.
Since we're going through doc review, it should actually be Manhattan.
Member
There was a problem hiding this comment.
Did you leave this requested change intentionally out?
Contributor
Author
There was a problem hiding this comment.
Did you leave this requested change intentionally out?
No, not intentionally. I didn't see it on this page for some reason. Will make the change now
| --------------- | ||
|
|
||
| Q: I get an error that theres now device connected: | ||
| Q: I get an error that there's now device connected: |
Member
|
Thanks for that :) |
SergioRAgostinho
added
module: docs
and removed
needs: author reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3