Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PLYReader is_dense behavior #2133

Merged
merged 5 commits into from
Mar 6, 2018
Merged

Fix PLYReader is_dense behavior #2133

merged 5 commits into from
Mar 6, 2018

Conversation

SergioRAgostinho
Copy link
Member

Superseedes #1460
Fixes: #1455

@SergioRAgostinho SergioRAgostinho added the needs: code review Specify why not closed/merged yet label Dec 8, 2017
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.9.0 milestone Jan 25, 2018
@taketwo
Copy link
Member

taketwo commented Feb 26, 2018

Can you please rebase this?

@taketwo
Copy link
Member

taketwo commented Feb 27, 2018

PCL.Octree_Pointcloud_Adjacency test failed on AppVeyor. Weird.

@SergioRAgostinho SergioRAgostinho added needs: more work Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Mar 4, 2018
@SergioRAgostinho
Copy link
Member Author

It's not triggering on Mac with the current master. I've rebased and I'll push again to check results. If it fails again it's better to have @UnaNancyOwen have a look to see if it fails also on his environment.

@SergioRAgostinho SergioRAgostinho added needs: code review Specify why not closed/merged yet module: io changelog: behavior change Meta-information for changelog generation and removed needs: more work Specify why not closed/merged yet labels Mar 4, 2018
@SergioRAgostinho
Copy link
Member Author

It went through 👍

@taketwo taketwo removed the needs: code review Specify why not closed/merged yet label Mar 6, 2018
@taketwo taketwo merged commit 8824a27 into PointCloudLibrary:master Mar 6, 2018
@SergioRAgostinho SergioRAgostinho mentioned this pull request Aug 6, 2018
Closed
@SergioRAgostinho SergioRAgostinho mentioned this pull request Aug 25, 2018
Merged
@SergioRAgostinho SergioRAgostinho deleted the ply_is_dense branch September 12, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
changelog: behavior change Meta-information for changelog generation module: io
Projects
None yet
Milestone
pcl-1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioRAgostinho @taketwo @VictorLamoine