Fix PLYReader is_dense behavior - #2133
Merged
Merged
Conversation
Member
|
Can you please rebase this? |
SergioRAgostinho
force-pushed
the
ply_is_dense
branch
from
February 27, 2018 08:42
67fbb6e to
ef3b117
Compare
Member
|
|
SergioRAgostinho
added
needs: more work
Member
Author
|
It's not triggering on Mac with the current master. I've rebased and I'll push again to check results. If it fails again it's better to have @UnaNancyOwen have a look to see if it fails also on his environment. |
SergioRAgostinho
force-pushed
the
ply_is_dense
branch
from
March 4, 2018 11:27
ef3b117 to
316c26d
Compare
SergioRAgostinho
added
needs: code review
Member
Author
|
It went through 👍 |
taketwo
approved these changes
Mar 6, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseedes #1460
Fixes: #1455