Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress log when PCL_FIND_QUIETLY is turned on. #2032

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Suppress log when PCL_FIND_QUIETLY is turned on. #2032

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a63ad7
Suppress log when PCL_FIND_QUIETLY is turned on.
Oct 18, 2017
d71520e
Change the case to make it in consist with OpenNI2.
Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PCLConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ endmacro(find_qhull)

#remove this as soon as libopenni is shipped with FindOpenni.cmake
macro(find_openni)
if(PCL_FIND_QUIETLY)
set(openni_FIND_QUIETLY TRUE)
Copy link
Member

@UnaNancyOwen UnaNancyOwen Oct 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be all lowercase in case of OpenNI2. (PCLConfig.cmake.in#L223)
If there is no reason, Please adjust accordingly.

-    set(openni_FIND_QUIETLY TRUE)
+    set(OpenNI_FIND_QUIETLY TRUE)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason to use all lowercase is because it should be the same as the first parameter in the call find_package_handle_standard_args.

pcl/PCLConfig.cmake.in

Line 211 in 41783c7

find_package_handle_standard_args(openni DEFAULT_MSG OPENNI_LIBRARY OPENNI_INCLUDE_DIRS)

I'll change them all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good. Thanks,

endif()

if(NOT OPENNI_ROOT AND ("@HAVE_OPENNI@" STREQUAL "TRUE"))
set(OPENNI_INCLUDE_DIRS_HINT "@OPENNI_INCLUDE_DIRS@")
get_filename_component(OPENNI_LIBRARY_HINT "@OPENNI_LIBRARY@" PATH)
Expand Down