Fix the incorrect include directory. #2024
Conversation
|
I'm confused about where the device headers should be installed. According to the source files, they should be put in the "device" directory in the module's include path; but in the "CMakeLists.txt" they are directly installed to the include path. This commit doesn't really fix the problem. Perhaps the correct choice is to fix those "CMakeLists.txt". |
|
Then should this be fixed or just let it go? |
|
It's a bug and needs to be fixed, with the instructions I mentioned. |
ShiningPluto
force-pushed
the
fix_include
branch
from
f029c8a
to
1066a3f
Compare
gpu/utils/CMakeLists.txt
Outdated
| @@ -26,5 +26,6 @@ if(build) | |||
| PCL_MAKE_PKGCONFIG("${LIB_NAME}" "${SUBSYS_NAME}" "${SUBSYS_DESC}" "${SUBSYS_DEPS}" "${EXT_DEPS}" "" "" "") | |||
|
|
|||
| # Install include files | |||
| PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_PATH}" ${dev_incs} ${incs} ${srcs}) | |||
| PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_PATH}" ${incs} ${srcs}) | |||
There was a problem hiding this comment.
Passing ${srcs} in here doesn't make much sense. Supposedly everything which is in src/ is not to be distributed/installed, only used for compiling pcl. Does not including it, prevent you from compiling the module?
There was a problem hiding this comment.
Not including it won't prevent me from compiling the module. I can't figure out why the ${srcs} should be installed either.
ShiningPluto
force-pushed
the
fix_include
branch
from
1066a3f
to
cb27ee2
Compare
The installed pcl_gpu_utils headers are placed in pcl/gpu/utils not pcl/gpu/utils/device.