Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tools build in CI. #2003

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

SergioRAgostinho
Copy link
Member

Disable the building of tools in the CI, 'till they get properly refactored (somehow )

@frozar
Copy link
Contributor

frozar commented Sep 22, 2017

Sad news...

@taketwo taketwo merged commit 4936c5f into PointCloudLibrary:master Sep 22, 2017
@frozar
Copy link
Contributor

frozar commented Sep 26, 2017

I send a mail to the Travis CI support recently (it was to report a bug in their interface). They answer me:

We have increased the maximum build time to 70 minutes for the repository PointCloudLibrary/pcl, so you will run less into false negatives.

It's really a great news, and I think that we can enable again the building of tools. What do you think about it?

PS: if you'd like read the emails, just give me your mail address on IRC (or send email at fabien.rozar@gmail.com)

@taketwo
Copy link
Member

taketwo commented Sep 26, 2017

Fabien, that's indeed great news, thanks for reaching out to them. We should have tried this "social engineering" approach instead of "workarounds hacking" much earlier 😆

I've restarted one the old jobs for tools, let's see if it succeeds. And with this new limit we can also try merge together some of the extended test jobs to avoid superfluous library re-compilation, e.g. test-ext-1 and test-ext-2.

@frozar
Copy link
Contributor

frozar commented Sep 26, 2017

@taketwo : Yes, definitely it's a great news 😄

If you'd like the rework the exist test, hope to you, I cannot spend too much time to develop PCL. As you can see, I open a pull request for the build of tools, and I'll look closely at the build status.

@frozar
Copy link
Contributor

frozar commented Sep 26, 2017

@taketwo : the old job you launched previously passed the build successfully: Champagne!

@SergioRAgostinho
Copy link
Member Author

OMG!!!!! Good job @frozar ! Btw, why not enable apps then as well? 😉 (It's just uncommenting the other one)

@frozar
Copy link
Contributor

frozar commented Sep 26, 2017

I didn't uncomment it because I didn't know if these tests work or not. Up to you to try them locally, check if everything is alright (ideally), and propose a pull request ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants