tools: Add option to write normals to mesh_sampling #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Added screenshots for reference) This should be easy to test if a newcomer wants to give it a try... |
taketwo
reviewed
Jan 19, 2017
| } | ||
| else | ||
| { | ||
| savePCDFileASCII(argv[pcd_file_indices[0]], *res); |
There was a problem hiding this comment.
What is the difference between res and cloud_1? Why when normals are not required you effectively output cloud_1, and when they are required, you output res?
There was a problem hiding this comment.
Good catch!
res is the voxelized cloud. I should fix my typo and maybe rename res to something more meaningful.
There was a problem hiding this comment.
Since you'll be updating your commit anyway, please insert spaces between function names and braces to match PCL style.
|
Looks good to me, thanks! |
taketwo
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be relatively easy to review, as it should work with any obj/ply file.
Example before:
Example after:
