Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ply file header parsing #1750

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

Slonegg
Copy link
Contributor

@Slonegg Slonegg commented Nov 3, 2016

I have an assertion with debug PCL when parsing ply file saved by CloudCompare. I think this pull request should fix it.

ply
format binary_little_endian 1.0
comment Author: CloudCompare (TELECOM PARISTECH/EDF R&D)
obj_info Generated by CloudCompare!
element vertex 15070
property float x
property float y
property float z
property uchar red
property uchar green
property uchar blue
property float nx
property float ny
property float nz
element face 29996
property list uchar int vertex_indices
end_header

@Slonegg Slonegg closed this Nov 4, 2016
@Slonegg Slonegg reopened this Nov 4, 2016
@taketwo
Copy link
Member

taketwo commented Nov 4, 2016

This assert served to guard accesses to st[2] in following lines. Would be nice if the patch preserved this behavior as well.

@taketwo taketwo added this to the pcl-1.8.1 milestone Nov 4, 2016
@taketwo taketwo added the needs: author reply Specify why not closed/merged yet label Nov 4, 2016
@Slonegg
Copy link
Contributor Author

Slonegg commented Nov 4, 2016

@taketwo you right, I wasn't paying enough attention. I think it's reasonable to have if there, seems that obj_info can be followed by any string.

@taketwo taketwo added status: ready to merge and removed needs: author reply Specify why not closed/merged yet labels Nov 4, 2016
@SergioRAgostinho SergioRAgostinho merged commit 2548671 into PointCloudLibrary:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants