Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-free lena-grayscale.png #1676

Merged
merged 1 commit into from
Aug 16, 2016

Conversation

jspricke
Copy link
Member

@jspricke
Copy link
Member Author

as far as I've found, this image is used nowhere.

@SergioRAgostinho
Copy link
Member

Did our CI workers got downgraded or something? it did not finish building the project under 2 hours...

@taketwo
Copy link
Member

taketwo commented Aug 16, 2016

As far as I can see, in the last run Travis was not able to pick up pre-compiled VTK, Flann, etc. from cache and needed to recompile them.

@taketwo
Copy link
Member

taketwo commented Aug 16, 2016

I can not find any details about when and why Travis invalidates caches, but let's assume it happened because there was not activity in the master branch for the last two months.

In the last couple of runs all the dependencies were successfully rebuilt, but since these were "pull request runs", the cache was not uploaded to the cloud. So I will merge this one to make sure that the dependencies are rebuilt and cached again.

@taketwo taketwo merged commit 40c0a51 into PointCloudLibrary:master Aug 16, 2016
@SergioRAgostinho
Copy link
Member

I was gonna say to merge #1677 instead. I wanted to see if this broke any of the tests. I find it strange that we had an unused image in the repo.

@taketwo
Copy link
Member

taketwo commented Aug 16, 2016

Too late :) But ag reveals no references to this image by name. I can't imagine that there is a test case somewhere which constructs the filename by concatenating parts.

@jspricke jspricke deleted the remove_nonfree_lenna branch August 16, 2016 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants