SAC Models Refactoring: isModelValid(), ver. 2 #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function returns the value of protected member field model_size_. It is the responsibility of deriving classes to set it appropriately. All the classes in PCL are updated to do so.
The default implementation verifies that the number of coefficients in the supplied model is as expected. Specific SAC models extend this function by checking the user constraints (when applicable).
|
Looks nice 👍 Cheers, |
|
Yes, that's the plan. |
jspricke
added a commit
that referenced
this pull request
Oct 9, 2015
SAC Models Refactoring: isModelValid(), ver. 2
|
I'm on it |
|
See #1388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new edition of #1075. As discussed, rather than having a global map, the model sizes are stored in a protected member field. The rest is the same as before.