-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
PointCloud interface consolidation and various optimizations #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8a4f3f1
to
4e78bf2
Compare
Things to do:
|
086701c
to
5e8a6a5
Compare
e61dff4
to
25177e4
Compare
6fa4a2b
to
bfa6dc6
Compare
057537d
to
0e4a924
Compare
a8b8501
to
6bf3677
Compare
…ts::begin and PointCloud::points::end
…nts::front and PointCloud::points::back
cae3324
to
aafb387
Compare
@taketwo I think this can be merged and continue in a different PR the extra interface consolidation task. It's a pain to rebase it everytime something changes. |
This pull request has been automatically marked as stale because it hasn't had Come back whenever you have time. We look forward to your contribution. |
This is a big change and I'm still working on it, but I wanted to get it out there as some other people are working on similar things.
This should supersede #1343 and #1340 and eventually fix #1306.
The end goal of this PR is to replace the std::vector structure of PointCloud to something else that doesn't have the same shortcomings. But there are other issues that this PR will fix:
Take in account this is work in progress PR, I'm still splitting bigger commits in smaller ones so it can easily reviewed. I'm creating two types of commits: the big ones, that are just search & replace changes, and the rest that fix code or standardize it.
With all these changes points can be made protected (already tried and it compiles just fine).