updated estimateProjectionMatrix() to make the down-sampled image have t... #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| for (unsigned xIdx = 0; xIdx < input_->width; xIdx += xSkip, idx += xSkip) | ||
| for (unsigned xIdx = 0, idx2 =idx; xIdx < input_->width; xIdx += xSkip, idx2 += xSkip) |
There was a problem hiding this comment.
Please remove extra two spaces before for and add a space after equal sign in =idx.
|
Hi, sorry for the delay. Could you please update the pull request? |
…e the same number of points for each row (e.g. given a 5x5 input with x/yskip=2, the downsampled image now has 3 points for each row instead of 3,2,3 points for each row)
|
No problem. Sorry about that. Should be good now |
taketwo
added a commit
that referenced
this pull request
Apr 14, 2015
updated estimateProjectionMatrix() to make the down-sampled image have t...
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...he same number of points for each row (e.g. given a 5x5 input with x/yskip=2, the downsampled image now has 3 points for each row instead of 3,2,3 points for each row), which could cause segfault if the user assumes all rows having the same number of points