Closed
Conversation
Member
|
Hi, could you have a look at a new class introduced in #586? Do you think it may be useful here? |
Contributor
Author
|
I think it could be useful, except the downsample_all_data_=false case. |
Member
|
This addresses #1413. Searched the issues put forgot to check pull requests. I also wrote a fix plus a test but only for VoxelGrid. This pull request is missing patching voxel_grid.cpp:177. I'll try to incorporate #586, this following week. |
SergioRAgostinho
added a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Nov 8, 2015
Fixes PointCloudLibrary#1413, based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586.
Merged
SergioRAgostinho
added a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Nov 12, 2015
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
SergioRAgostinho
added a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Nov 12, 2015
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
SergioRAgostinho
added a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Nov 16, 2015
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downsample the alpha component too