Fix warnings reported by clang #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> robot_eye_grabber.cpp:196:21: warning: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
> image_viewer.hpp:118:15: warning: unused variable 'image_height_f' [-Wunused-variable] > image_viewer.hpp:177:15: warning: unused variable 'image_height_f' [-Wunused-variable]
> digital_elevation_map.h:39:9: warning: unknown pragma ignored [-Wunknown-pragmas] `#pragma warning(disable : 4996)` is MSVS-only. Further, it seems to be added here to prevent warnings originating from "point_types.h". Therefore if we really need it, it should be re-added with MSVC ifdef and directly in "point_types.h".
> test_copy_make_borders.cpp:55:23: warning: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare] ... and 18 more.
> test_quad_mesh.cpp:372:13: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare]
> test_io.cpp:799:17: warning: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Wsign-compare]
> grabcut_segmentation.hpp:272:25: warning: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Wsign-compare]
> ni_agast.cpp:233:13: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
> ni_brisk.cpp:193:13: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
> trajkovic_3d.h:142:42: warning: unused parameter 'normals' [-Wunused-parameter]
> trajkovic_3d.hpp:237:21: warning: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Wsign-compare]
> trajkovic_2d.hpp:223:21: warning: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Wsign-compare]
> openni_tracking.cpp:452:72: warning: unused parameter 'normals' [-Wunused-parameter]
> stereo_ground_segmentation.cpp:269:25: warning: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Wsign-compare] ... and 5 more.
|
+1 otherwise, just waiting for Travis. |
jspricke
added a commit
that referenced
this pull request
Jan 18, 2015
Fix warnings reported by clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: commit e5eb817 changes (fixes) API of
TrajkovicKeypoint3D.