Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to RSSDK 2.0 grabber #3467

Closed
3 tasks
SergioRAgostinho opened this issue Nov 14, 2019 · 1 comment · Fixed by #3473
Closed
3 tasks

Changes to RSSDK 2.0 grabber #3467

SergioRAgostinho opened this issue Nov 14, 2019 · 1 comment · Fixed by #3473

Comments

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Nov 14, 2019

OK. My plan was to compile and include these files only under Windows and fork a new a issue to address the failures under Linux.

Originally posted by @SergioRAgostinho in #2214 (comment)

Expanding on this topics with a list of items to address before the release:

  • Restrict the building the grabber to Windows only.
  • Address my final review comments in the original PR and remove some unnecessary checks.
  • Fix warnings raise from not using std:: int types.
@SergioRAgostinho SergioRAgostinho changed the title Changes to perform of RSSDK 2.0 grabber Changes on RSSDK 2.0 grabber Nov 14, 2019
@SergioRAgostinho SergioRAgostinho mentioned this issue Nov 14, 2019
11 tasks
@SergioRAgostinho SergioRAgostinho changed the title Changes on RSSDK 2.0 grabber Changes to RSSDK 2.0 grabber Nov 14, 2019
@taketwo
Copy link
Member

taketwo commented Nov 15, 2019

One more thing: fix warnings, there are plenty because of using int types without std:: prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants