Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTEST_USE_OWN_TR1_TUPLE still required? #2824

Closed
SunBlack opened this issue Feb 4, 2019 · 1 comment
Closed

GTEST_USE_OWN_TR1_TUPLE still required? #2824

SunBlack opened this issue Feb 4, 2019 · 1 comment
Labels
module: test platform: windows

Comments

@SunBlack
Copy link
Contributor

SunBlack commented Feb 4, 2019 •
edited
Loading

Currently PCl code contains sometimes:

#if defined(_MSC_VER)
    #define GTEST_USE_OWN_TR1_TUPLE 0
#endif

In current googeltest code GTEST_USE_OWN_TR1_TUPLE is not even used anymore (see e.g. google/googletest@abc803e) and since we requires C++14 tuples should be always supported. So can we remove this defines?
@SunBlack SunBlack mentioned this issue Feb 4, 2019
Merged
@SergioRAgostinho
Copy link
Member

Makes sense to remove it 👍

@SunBlack SunBlack mentioned this issue Feb 5, 2019
Merged
@SunBlack SunBlack closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: test platform: windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SunBlack @SergioRAgostinho