Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MSVC 2013 (and below) support #2817

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Drop MSVC 2013 (and below) support #2817

merged 1 commit into from
Feb 4, 2019

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Feb 1, 2019

No description provided.

@SunBlack SunBlack force-pushed the drop_code_for_msvc_2013_and_below branch from 35f9822 to c4db36e Compare February 1, 2019 13:58
UnaNancyOwen
UnaNancyOwen approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@UnaNancyOwen UnaNancyOwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SunBlack Thanks! LGTM 👍
By the way, I want to hear your opinion about other points.
What do you think about this file? Do you think MSVC_2010_FIX is still necessary?
https://github.com/PointCloudLibrary/pcl/blob/pcl-1.9.1/surface/include/pcl/surface/3rdparty/poisson4/binary_node.h

@SunBlack
Copy link
Contributor Author

SunBlack commented Feb 4, 2019

What do you think about this file? Do you think MSVC_2010_FIX is still necessary?
https://github.com/PointCloudLibrary/pcl/blob/pcl-1.9.1/surface/include/pcl/surface/3rdparty/poisson4/binary_node.h

No idea. This code is enabled for all platform, so it's not MSVC specific and we don't touch 3rdParty code so I don't really care about this ;).

@UnaNancyOwen
Copy link
Member

@SunBlack Thanks!

@UnaNancyOwen UnaNancyOwen merged commit 3ffb4fd into PointCloudLibrary:master Feb 4, 2019
@SunBlack
Copy link
Contributor Author

SunBlack commented Feb 4, 2019

Other question is if we really still need GTEST_USE_OWN_TR1_TUPLE - current googletest code seems not to use this define anymore. But I think this is something for another MR.

@SunBlack SunBlack deleted the drop_code_for_msvc_2013_and_below branch February 4, 2019 14:05
@UnaNancyOwen
Copy link
Member

current googletest code seems not to use this define anymore.

Are googletests that are not using GTEST_USE_OWN_TR1_TUPLE already released?
If not released, I think that it should not yet remove.

@SunBlack
Copy link
Contributor Author

SunBlack commented Feb 4, 2019

Moved discussion about this into separate issue (#2824)

@taketwo taketwo changed the title Drop code for MSVC 2013 and below Drop MSVC 2013 (and below) support Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnaNancyOwen UnaNancyOwen UnaNancyOwen approved these changes

Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @UnaNancyOwen @taketwo